Re: [PATCH v2] gpio:amdpt:add new device ID and 24-pin support

[Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>]

On Wed, Dec 08, 2021 at 06:36:21PM +0800, Yuchang Hsu wrote:

Thanks for update, my comments below.

> Hi Andy Shevchenko,

> How and what to put the Changelog after '---'?i just remove '---'.

No, you shouldn't remove it, instead you should add the text after it in a free
form of what you have done in the submitted version in comparison to the
previous one.

To achieve this use `git format-patch ...` and then edit it and then send it
with a help of `git send-email ...`.

> This patch adds a ACPI HID(AMDIF031) and pin number in the pt_gpio_acpi_match.

"This patch adds a ..." --> "Add an ..."

> And We retrieve pin number supporting by device_get_match_data().

"And " --> ""
"supporting " --> ""

So, waiting for v3.

-- 
With Best Regards,
Andy Shevchenko