On 12/6/21 5:16 AM, Hans Verkuil wrote: > Set the direction directly without calling pinctrl_gpio_direction(). > This avoids the mutex_lock() calls in that function, which would > invalid the can_sleep = false. make invalid, or invalidate? With that fixed: Reviewed-by: Florian Fainelli <f.fainelli@xxxxxxxxx> -- Florian
Re: [RFC PATCH 2/3] pinctrl-bcm2835: don't call pinctrl_gpio_direction()
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: [RFC PATCH 2/3] pinctrl-bcm2835: don't call pinctrl_gpio_direction()
- From: Florian Fainelli <f.fainelli@xxxxxxxxx>
- Date: Mon, 6 Dec 2021 09:29:35 -0800
- In-reply-to: <20211206131648.1521868-3-hverkuil-cisco@xs4all.nl>
- References: <20211206131648.1521868-1-hverkuil-cisco@xs4all.nl> <20211206131648.1521868-3-hverkuil-cisco@xs4all.nl>
- User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0
- References:
- [RFC PATCH 0/3] pinctrl: can_sleep and pinctrl_gpio_direction
- From: Hans Verkuil
- [RFC PATCH 2/3] pinctrl-bcm2835: don't call pinctrl_gpio_direction()
- From: Hans Verkuil
- [RFC PATCH 0/3] pinctrl: can_sleep and pinctrl_gpio_direction
- Prev by Date: Re: [PATCH v2 2/2] ARM: dts: gpio-ranges property is now required
- Next by Date: Re: [PATCH v5 1/2] dt-bindings: pinctrl: qcom: Add SDX65 pinctrl bindings
- Previous by thread: [RFC PATCH 2/3] pinctrl-bcm2835: don't call pinctrl_gpio_direction()
- Next by thread: Re: [RFC PATCH 2/3] pinctrl-bcm2835: don't call pinctrl_gpio_direction()
- Index(es):
 |