On Thu, Dec 2, 2021 at 6:59 PM Felix Fietkau <nbd@xxxxxxxx> wrote: > I just looked at the datasheet and the driver code again, and I think > EN7523 is too strange for proper generic GPIO support. Yup I see that John explained it to me in the past, no problem. Let's do it like this then, but just drop select GPIO_GENERIC from KConfig since it's not used. With that oneliner change: Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx> Yours, Linus Walleij