Re: [PATCH 2/2] libgpiod: Remove dummy declaration gpiod_line_config_get_event_clock()

[Bartosz Golaszewski <brgl@xxxxxxxx>]

On Fri, Nov 26, 2021 at 10:07 AM Viresh Kumar <viresh.kumar@xxxxxxxxxx> wrote:
>
> gpiod_line_config_get_event_clock() isn't implemented, and just has the
> declaration available. Drop it.
>
> Signed-off-by: Viresh Kumar <viresh.kumar@xxxxxxxxxx>
> ---
>  include/gpiod.h | 12 ------------
>  1 file changed, 12 deletions(-)
>
> diff --git a/include/gpiod.h b/include/gpiod.h
> index 44deafc83c11..0bc0ceee4b76 100644
> --- a/include/gpiod.h
> +++ b/include/gpiod.h
> @@ -777,18 +777,6 @@ void gpiod_line_config_set_event_clock_subset(struct gpiod_line_config *config,
>                                               unsigned int num_offsets,
>                                               const unsigned int *offsets);
>
> -/**
> - * @brief Get the event clock setting for a given line.
> - * @param config Line config object.
> - * @param offset Line offset for which to read the event clock setting.
> - * @return Event clock setting that would have been used for given offset if
> - *         the config object was used in a request at the time of the call.
> - * @note If an offset is used for which no config was provided, the function
> - *       will return the global default value.
> - */
> -int gpiod_line_config_get_event_clock(struct gpiod_line_config *config,
> -                                     unsigned int offset);
> -
>  /**
>   * @brief Set the output value for a single offset.
>   * @param config Line config object.
> --
> 2.31.1.272.g89b43f80a514
>

But we want this function - it should get implemented, not dropped. :)

It's actually added in the devel branch for line_config accessors.

Bart