On Thu, Nov 18, 2021 at 01:26:28PM +0200, Andy Shevchenko wrote: > On Thu, Nov 18, 2021 at 11:56:48AM +0100, Hans de Goede wrote: > > Offset/pin 0 is a perfectly valid offset, so stop using it to have > > the special meaning of interrupt line not used in the intr_lines. > > > > Instead introduce a new special INTR_LINE_UNUSED value which is never > > a valid offset and use that to indicate unused interrupt lines. > > ... > > > +#define INTR_LINE_UNUSED U32_MAX > > Funny, I have had something similar in my local branch for a few years ;-) > > +#define CHV_INVALID_HWIRQ ((unsigned int)INVALID_HWIRQ) I will rename this when applying. I assume there is no objection on doing it. -- With Best Regards, Andy Shevchenko
Re: [PATCH v2 1/3] pinctrl: cherryview: Don't use pin/offset 0 to mark an interrupt line as unused
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: [PATCH v2 1/3] pinctrl: cherryview: Don't use pin/offset 0 to mark an interrupt line as unused
- From: Andy Shevchenko <andriy.shevchenko@xxxxxxxxx>
- Date: Fri, 26 Nov 2021 19:43:07 +0200
- In-reply-to: <YZY4ZA80QpJQFqOj@smile.fi.intel.com>
- Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
- References: <20211118105650.207638-1-hdegoede@redhat.com> <YZY4ZA80QpJQFqOj@smile.fi.intel.com>
- Follow-Ups:
- References:
- Prev by Date: Re: [PATCH v4 12/12] gpio: Add support for Airoha EN7523 GPIO controller
- Next by Date: Re: [PATCH v2 1/3] pinctrl: cherryview: Don't use pin/offset 0 to mark an interrupt line as unused
- Previous by thread: Re: [PATCH v2 1/3] pinctrl: cherryview: Don't use pin/offset 0 to mark an interrupt line as unused
- Next by thread: Re: [PATCH v2 1/3] pinctrl: cherryview: Don't use pin/offset 0 to mark an interrupt line as unused
- Index(es):
 |