Re: [PATCH v3 2/2] dt-bindings: pinctrl: add bindings for Milbeaut pin controller

[Sugaya Taichi <sugaya.taichi@xxxxxxxxxxxxx>]

On 2021/11/26 10:14, Linus Walleij wrote:
> On Thu, Nov 25, 2021 at 10:58 AM Sugaya Taichi
> <sugaya.taichi@xxxxxxxxxxxxx> wrote:
>
> > Add Device Tree bindings documentation for pin controller of
> > the Milbeaut SoCs.
> >
> > Signed-off-by: Sugaya Taichi <sugaya.taichi@xxxxxxxxxxxxx>
>
> What is weird about this binding is what is not there:
> this is just GPIO, where are the pin mux and config
> nodes? The driver surely tries to use them.
>
> Please use the existing standard bindings for functions
> and groups etc, check the other bindings.
>
> Yours,
> Linus Walleij

Thank you for comments.

I realized this is just GPIO by your comment.
OK I check them more.

Thanks,
Taichi Sugaya

> > ---
> >   .../pinctrl/socionext,milbeaut-pinctrl.yaml        | 51 ++++++++++++++++++++++
> >   1 file changed, 51 insertions(+)
> >   create mode 100644 Documentation/devicetree/bindings/pinctrl/socionext,milbeaut-pinctrl.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/pinctrl/socionext,milbeaut-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/socionext,milbeaut-pinctrl.yaml
> > new file mode 100644
> > index 0000000..78bc2d4
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/pinctrl/socionext,milbeaut-pinctrl.yaml
> > @@ -0,0 +1,51 @@
> > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/pinctrl/socionext,milbeaut-pinctrl.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Milbeaut SoCs pin controller
> > +
> > +maintainers:
> > +  - Taichi Sugaya <sugaya.taichi@xxxxxxxxxxxxx>
> > +
> > +description: |
> > +  Bindings for memory-mapped pin controller of the Milbeaut SoCs.
> > +
> > +properties:
> > +  $nodename:
> > +    pattern: "pinctrl"
> > +
> > +  compatible:
> > +    enum:
> > +      - socionext,milbeaut-m10v-pinctrl
> > +
> > +  reg:
> > +    maxItems: 1
> > +
> > +  reg-names:
> > +    const: "pinctrl"
> > +
> > +  gpio-controller: true
> > +
> > +  "#gpio-cells":
> > +    const: 2
> > +
> > +required:
> > +  - compatible
> > +  - reg
> > +  - reg-names
> > +  - gpio-controller
> > +  - "#gpio-cells"
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > +  - |
> > +    pinctrl: pinctrl@1d022000 {
> > +        compatible = "socionext,milbeaut-m10v-pinctrl";
> > +        reg = <0x1d022000 0x1000>;
> > +        reg-names = "pinctrl";
> > +        gpio-controller;
> > +        #gpio-cells = <2>;
> > +    };
> > --
> > 2.7.4