Hi all, Here's a series of small fixes that Andy made comments about, after the driver was already in the pinctrl tree. Changes since v1[1]: - No actual code changes (git diff pinctrl_apple_fixes_v1 pinctrl_apple_fixes_v2 is empty) - Split non-whitespace changes out from the first commit. - Add suggested-by tags Thanks, Joey A branch can be found here: https://gitlab.arm.com/linux-arm/jg-open/-/tree/pinctrl_apple_fixes_v2 Joey Gouly (11): pinctrl: apple: fix some formatting issues pinctrl: apple: add missing comma pinctrl: apple: use C style comment pinctrl: apple: add missing bits.h header pinctrl: apple: handle regmap_read errors pinctrl: apple: make apple_gpio_get_direction more readable pinctrl: apple: give error label a specific name pinctrl: apple: remove gpio-controller check pinctrl: apple: don't set gpio_chip.of_node pinctrl: apple: use modulo rather than bitwise and pinctrl: apple: return an error if pinmux is missing in the DT drivers/pinctrl/pinctrl-apple-gpio.c | 103 ++++++++++++--------------- 1 file changed, 46 insertions(+), 57 deletions(-) -- 2.17.1