Re: [PATCH] virtio_gpio: drop packed attribute

[Bartosz Golaszewski <brgl@xxxxxxxx>]

On Mon, Nov 1, 2021 at 10:11 AM Michael S. Tsirkin <mst@xxxxxxxxxx> wrote:
>
> Declaring the struct packed here is mostly harmless,
> but gives a bad example for people to copy.
> As the struct is packed and aligned manually,
> let's just drop the attribute.
>
> Signed-off-by: Michael S. Tsirkin <mst@xxxxxxxxxx>
> ---
>  include/uapi/linux/virtio_gpio.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/uapi/linux/virtio_gpio.h b/include/uapi/linux/virtio_gpio.h
> index 0445f905d8cc..25c95a034674 100644
> --- a/include/uapi/linux/virtio_gpio.h
> +++ b/include/uapi/linux/virtio_gpio.h
> @@ -25,7 +25,7 @@ struct virtio_gpio_config {
>         __le16 ngpio;
>         __u8 padding[2];
>         __le32 gpio_names_size;
> -} __packed;
> +};
>
>  /* Virtio GPIO Request / Response */
>  struct virtio_gpio_request {
> --
> MST
>

Applied, thanks!

Bart