Re: [PATCH v5 4/5] pinctrl: add pinctrl/GPIO driver for Apple SoCs

[Andy Shevchenko <andy.shevchenko@xxxxxxxxx>]

On Mon, Nov 1, 2021 at 7:53 PM Joey Gouly <joey.gouly@xxxxxxx> wrote:
> On Sun, Oct 31, 2021 at 03:39:01PM +0200, Andy Shevchenko wrote:
> > On Wed, Oct 27, 2021 at 5:28 AM Joey Gouly <joey.gouly@xxxxxxx> wrote:

...

> > > +       ret = of_property_count_u32_elems(node, "pinmux");
> > > +       if (ret <= 0) {
> > > +               dev_err(pctl->dev,
> > > +                       "missing or empty pinmux property in node %pOFn.\n",
> > > +                       node);
> > > +               return ret;

if (ret == 0)
 dev_err();
 return 0;

> > This is incorrect. It always happens when somebody is in hurry :-)
> I don't understand which bit you are saying is incorrect here, can you expand on your comment?

See above.

-- 
With Best Regards,
Andy Shevchenko