Re: [RFC PATCH 1/4] dt-bindings: pincfg-node: Add "output-impedance" property

["Lad, Prabhakar" <prabhakar.csengg@xxxxxxxxx>]

Hi Rob,

Thank you for the review.

On Wed, Oct 6, 2021 at 10:14 PM Rob Herring <robh@xxxxxxxxxx> wrote:
>
> On Thu, Sep 30, 2021 at 01:16:27PM +0100, Lad Prabhakar wrote:
> > On RZ/G2L SoC for Group-B pins, output impedance can be configured.
> > This patch documents "output-impedance" property in pincfg-node.yaml so
> > that other platforms requiring such feature can make use of this property.
> >
> > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
> > ---
> >  Documentation/devicetree/bindings/pinctrl/pincfg-node.yaml | 4 ++++
> >  1 file changed, 4 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/pinctrl/pincfg-node.yaml b/Documentation/devicetree/bindings/pinctrl/pincfg-node.yaml
> > index 71ed0a9def84..cdcb23daeca2 100644
> > --- a/Documentation/devicetree/bindings/pinctrl/pincfg-node.yaml
> > +++ b/Documentation/devicetree/bindings/pinctrl/pincfg-node.yaml
> > @@ -114,6 +114,10 @@ properties:
> >      description: enable output on a pin without actively driving it
> >        (such as enabling an output buffer)
> >
> > +  output-impedance:
> > +    $ref: /schemas/types.yaml#/definitions/uint32
>
> Use standard unit suffix and drop the type.
>
Sure will do in the next version.

Cheers,
Prabhakar

> > +    description: set the pins output impedance at most X ohm
> > +
> >    output-low:
> >      type: boolean
> >      description: set the pin to output mode with low level
> > --
> > 2.17.1
> >
> >