On Mon, Oct 25, 2021 at 11:15 AM Bartosz Golaszewski <brgl@xxxxxxxx> wrote: > On Fri, Oct 22, 2021 at 3:44 PM Asmaa Mnebhi <asmaa@xxxxxxxxxx> wrote: A nit-pick that may be ignored... > > NULL, > > 0); > > > > + if (ret) { > > + dev_err(dev, "bgpio_init failed\n"); > > + return ret; > > + } > > + ...can we utilize an empty line before if (ret) { instead? -- With Best Regards, Andy Shevchenko