Re: [PATCH v3 1/2] ACPI: Add stubs for wakeup handler functions

[Andy Shevchenko <andy.shevchenko@xxxxxxxxx>]

On Tue, Oct 19, 2021 at 7:05 PM Mario Limonciello
<mario.limonciello@xxxxxxx> wrote:

Thanks! My comments below.

> commit ddfd9dcf270c ("ACPI: PM: Add acpi_[un]register_wakeup_handler()")

The commit

> added new functions for drivers to use during the s2idle wakeup path, but
> didn't add stubs for when CONFIG_ACPI wasn't set.
>
> Add those stubs in for other drivers to be able to use.

...

> +static inline int acpi_register_wakeup_handler(
> +       int wake_irq, bool (*wakeup)(void *context), void *context)

A bit of a strange indentation. Can wake_irq be on the previous line?

-- 
With Best Regards,
Andy Shevchenko