On Thu, Oct 21, 2021 at 8:42 PM Emil Renner Berthing <kernel@xxxxxxxx> wrote: > > Add StarFive Kconfig option to select SoC specific and common drivers > required for these SoCs. ... > +config SOC_STARFIVE > + bool "StarFive SoCs" > + select PINCTRL > + select RESET_CONTROLLER > + select SIFIVE_PLIC If this is well understood and platform related the above two are too generic. Why have you selected them? > + help > + This enables support for StarFive SoC platform hardware. Not too much to read here. What is the point of this help? I would elaborate what kind of platform it may support, what kind of drivers it selects due to necessity of the accomplishing the boot process, etc. -- With Best Regards, Andy Shevchenko
Re: [PATCH v2 01/16] RISC-V: Add StarFive SoC Kconfig option
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: [PATCH v2 01/16] RISC-V: Add StarFive SoC Kconfig option
- From: Andy Shevchenko <andy.shevchenko@xxxxxxxxx>
- Date: Fri, 22 Oct 2021 11:50:52 +0300
- In-reply-to: <20211021174223.43310-2-kernel@esmil.dk>
- References: <20211021174223.43310-1-kernel@esmil.dk> <20211021174223.43310-2-kernel@esmil.dk>
- Follow-Ups:
- Re: [PATCH v2 01/16] RISC-V: Add StarFive SoC Kconfig option
- From: Emil Renner Berthing
- Re: [PATCH v2 01/16] RISC-V: Add StarFive SoC Kconfig option
- References:
- [PATCH v2 00/16] Basic StarFive JH7100 RISC-V SoC support
- From: Emil Renner Berthing
- [PATCH v2 01/16] RISC-V: Add StarFive SoC Kconfig option
- From: Emil Renner Berthing
- [PATCH v2 00/16] Basic StarFive JH7100 RISC-V SoC support
- Prev by Date: Re: [PATCH v2 12/16] pinctrl: starfive: Add pinctrl driver for StarFive SoCs
- Next by Date: Re: [PATCH v2 01/16] RISC-V: Add StarFive SoC Kconfig option
- Previous by thread: [PATCH v2 01/16] RISC-V: Add StarFive SoC Kconfig option
- Next by thread: Re: [PATCH v2 01/16] RISC-V: Add StarFive SoC Kconfig option
- Index(es):
 |