Re: [PATCH] gpio: xgs-iproc: fix parsing of ngpios property

[Chris Packham <Chris.Packham@xxxxxxxxxxxxxxxxxxx>]

On 15/10/21 1:33 am, Jonas Gorski wrote:
> of_property_read_u32 returns 0 on success, not true, so we need to
> invert the check to actually take over the provided ngpio value.
>
> Fixes: 6a41b6c5fc20 ("gpio: Add xgs-iproc driver")
> Signed-off-by: Jonas Gorski <jonas.gorski@xxxxxxxxx>

Hmm I must have copied some error handling code and failed to invert the 
condition when I made the property optional.

Reviewed-by: Chris Packham <chris.packham@xxxxxxxxxxxxxxxxxxx>

> ---
> This is based on
> git://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-gpio.git,
> which is the tree for GPIO according to MAINTAINERS, but hasn't been
> updated since ~5.11 - is this still the correct tree?
>
> It doesn't matter much for this patch though, the driver is virtually
> untouched since then.
>
>   drivers/gpio/gpio-xgs-iproc.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpio/gpio-xgs-iproc.c b/drivers/gpio/gpio-xgs-iproc.c
> index ad5489a65d54..dd40277b9d06 100644
> --- a/drivers/gpio/gpio-xgs-iproc.c
> +++ b/drivers/gpio/gpio-xgs-iproc.c
> @@ -224,7 +224,7 @@ static int iproc_gpio_probe(struct platform_device *pdev)
>   	}
>   
>   	chip->gc.label = dev_name(dev);
> -	if (of_property_read_u32(dn, "ngpios", &num_gpios))
> +	if (!of_property_read_u32(dn, "ngpios", &num_gpios))
>   		chip->gc.ngpio = num_gpios;
>   
>   	irq = platform_get_irq(pdev, 0);