Re: [v4,8/9] arm64: dts: mediatek: add mt7986a support

[Marc Zyngier <maz@xxxxxxxxxx>]

On Mon, 04 Oct 2021 10:12:08 +0100,
Sam Shih <sam.shih@xxxxxxxxxxxx> wrote:
> 
> +		gic: interrupt-controller@c000000 {
> +			compatible = "arm,gic-v3";
> +			#interrupt-cells = <3>;
> +			interrupt-parent = <&gic>;
> +			interrupt-controller;
> +			reg = <0 0x0c000000 0 0x40000>,  /* GICD */
> +			      <0 0x0c080000 0 0x80000>,  /* GICR */
> +			      <0 0x0c400000 0 0x2000>,   /* GICC */
> +			      <0 0x0c410000 0 0x1000>,   /* GICH */
> +			      <0 0x0c420000 0 0x2000>;   /* GICV */
> +			interrupts = <GIC_PPI 9 IRQ_TYPE_LEVEL_HIGH>;
> +		};

Also, the GICD region is totally wrong. It is 64kB at all times. I
don't know where you get this 256kB figure from.

	M.

-- 
Without deviation from the norm, progress is not possible.