Re: [PATCH] pinctrl: renesas: rzg2l: Fix missing port register 21h

[Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>]

Hi Biju,

On Fri, Sep 24, 2021 at 11:03 AM Biju Das <biju.das.jz@xxxxxxxxxxxxxx> wrote:
> > -----Original Message-----
> > From: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
> > Sent: 24 September 2021 09:46
> > To: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> > Cc: Linus Walleij <linus.walleij@xxxxxxxxxx>; Linux-Renesas <linux-
> > renesas-soc@xxxxxxxxxxxxxxx>; open list:GPIO SUBSYSTEM <linux-
> > gpio@xxxxxxxxxxxxxxx>; Chris Paterson <Chris.Paterson2@xxxxxxxxxxx>; Biju
> > Das <biju.das@xxxxxxxxxxxxxx>; Prabhakar Mahadev Lad <prabhakar.mahadev-
> > lad.rj@xxxxxxxxxxxxxx>
> > Subject: Re: [PATCH] pinctrl: renesas: rzg2l: Fix missing port register
> > 21h
> >
> > On Wed, Sep 22, 2021 at 9:54 AM Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> > wrote:
> > > Remove the duplicate port register 22h and replace it with missing
> > > port register 21h.
> >
> > Thanks for your patch!
> >
> > > Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> >
> > Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> i.e. will queue
> > as a fix in renesas-pinctrl-for-v5.15, as this will become a dependency
> > when enabling SDHI/SD0, right?
>
> OK thanks. port register P21 corresponds to p17_0, p17_1 and p17_2.

Oh, this bug only affects P17_[012], not P18_[01] (which is used for I2C
on the SOM, not SD0, my mistake)?
As P17_[012] are not connected on the SOM, I'll postpone this to v5.16,
unless someone sees a good reason for not doing so.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds