Re: [PATCH libgpiod-v2] gpioinfo: Show edge detection and debounce period if enabled

[Ben Hutchings <ben.hutchings@xxxxxxxxxxxxx>]

On Mon, Sep 20, 2021 at 03:52:17PM +0200, Bartosz Golaszewski wrote:
> On Thu, Jul 29, 2021 at 1:46 AM Ben Hutchings <ben.hutchings@xxxxxxx> wrote:
[...]
> > @@ -166,6 +196,9 @@ static void list_lines(struct gpiod_chip *chip)
> >                 prinfo(&of, 13, "%s ",
> >                        active_low ? "active-low" : "active-high");
> >
> > +               if (debounce_period)
> > +                       printf("debounce=%lu ", debounce_period);
> 
> You should use prinfo here for formatting. But it would be even better
> if this became a flag - like the bias, drive etc settings and be shown
> inside the [] brackets at the end of the line - something like:
> "[pull-up, used, debounce-period=1000us]".
[...]

Well it's not a flag; it's an attribute with a value.  But if you
think it should be grouped with the flags anyway, I can do that.

Ben.

-- 
Ben Hutchings · Senior Embedded Software Engineer, Essensium-Mind · mind.be