On Thu, Sep 16, 2021 at 1:55 PM Marek Behún <kabel@xxxxxxxxxx> wrote: > Basically what I am trying to say here is that when user selects the > "led" function, the pin is controlled by PWM. There is no way for the > user to set "tristate on 1" setting but keep the pin controllable via > GPIO subsystem. > > What do you think of this? I still think there should be only one group > controlling one pin. But maybe someone will need to control the LED > with "tristate on 1" via GPIO. Should this be a separate, fourth > function, something like "gpio_led"? There are two ways to do this, either as Qualcomm does and have the GPIO mode be a unique function, or implement the three pincontrol override functions on struct pinmux_ops that makes it possible for the GPIO driver to just override pinmux entirely at runtime and mux the pins into GPIO mode on demand, and it seems that am37xx sets those? Yours, Linus Walleij