Re: [PATCH] gpio: ucb1400: Use proper header

[Andy Shevchenko <andy.shevchenko@xxxxxxxxx>]

On Sat, Aug 21, 2021 at 1:27 AM Linus Walleij <linus.walleij@xxxxxxxxxx> wrote:
>
> The UCB1400 implements a GPIO driver so it needs to include the
> <linux/gpio/driver.h> header, not the legacy <linux/gpio.h> header.
> Compile tested on pxa_defconfig.

...

>  #include <linux/module.h>
>  #include <linux/ucb1400.h>
> +#include <linux/gpio/driver.h>

Can you add it in an order?

...

> --- a/include/linux/ucb1400.h
> +++ b/include/linux/ucb1400.h
> @@ -23,7 +23,7 @@
>  #include <sound/ac97_codec.h>
>  #include <linux/mutex.h>
>  #include <linux/platform_device.h>
> -#include <linux/gpio.h>
> +#include <linux/gpio/driver.h>

Ditto (to some extent) and the question here, do you still need it
after adding to the C file?

-- 
With Best Regards,
Andy Shevchenko