Re: [PATCH v1 1/1] x86/platform: Increase maximum GPIO number for X86_64

[Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>]

On Mon, Aug 16, 2021 at 03:25:13PM +0200, Rafael J. Wysocki wrote:
> On Fri, Aug 6, 2021 at 4:44 PM Andy Shevchenko
> <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
> >
> > By default the 512 GPIOs is a maximum on any x86 platform.
> > With, for example, Intel Tiger Lake-H the SoC based controller
> > occupies up to 480 pins. This leaves only 32 available for
> > GPIO expanders or other drivers, like PMIC. Hence, bump the
> > maximum GPIO number to 1024 for X86_64 and leave 512 for X86_32.

Thanks for review, my answers below.

> > +# The GPIO number here must be sorted by descending number. In case of
> > +# a multiplatform kernel, we just want the highest value required by the
> > +# selected platforms.
> > +config ARCH_NR_GPIO
> > +       int
> > +       default 1024 if X86_64
> > +       default 512 if X86_32
> > +       default 0
> 
> Wouldn't
> 
> default 1024 if X86_64
> default 512
> 
> be sufficient?
> 
> It's either X86_64 or X86_32 anyway AFAICS.

I guess so.

> > +       help
> > +         Maximum number of GPIOs in the system.
> > +
> > +         If unsure, leave the default value.

Btw, what do you think. do we need comment above and help text here? I copied
these from ARM, but I'm not sure it would be useful on x86 as much.


-- 
With Best Regards,
Andy Shevchenko