Re: [RFC PATCH 1/4] dt-bindings: interrupt-controller: Add Renesas RZ/G2L Interrupt Controller

["Lad, Prabhakar" <prabhakar.csengg@xxxxxxxxx>]

Hi Linus,

Thank you for the review.

On Wed, Aug 11, 2021 at 1:10 PM Linus Walleij <linus.walleij@xxxxxxxxxx> wrote:
>
> On Tue, Aug 3, 2021 at 7:51 PM Lad Prabhakar
> <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx> wrote:
>
> > +description: |
> > +  The RZ/G2L Interrupt Controller is a front-end for the GIC found on Renesas RZ/G2L SoC's
> > +    - IRQ sense select for 8 external interrupts, mapped to 8 GIC SPI interrupts,
> > +    - GPIO pins used as external interrupt input pins, mapped to 32 GIC SPI interrupts,
> > +    - NMI edge select.
>
> Not that we don't have weird documentation but what on earth is an
> "NMI edge"???
>
On this SoC NMI is not treated as an NMI exception, the irqc has bits
to select the NMI interrupt (Rising/Falling-edge) detection.

> I know about rising and falling edges, and I know about non-maskable
> interrupts. But NMI edge? Maybe expand this to explain what it is?
>
sure will add more details on the above.

Cheers,
Prabhakar