Re: arm64: dts: mt8183: Incorrect mediatek,pull-*-adv values

[Chen-Yu Tsai <wenst@xxxxxxxxxxxx>]

On Mon, Jul 26, 2021 at 4:50 PM Hsin-Yi Wang <hsinyi@xxxxxxxxxxxx> wrote:
>
> On Mon, Jul 26, 2021 at 4:20 PM Chen-Yu Tsai <wenst@xxxxxxxxxxxx> wrote:
> >
> > Hi,
> >
> > I was looking at MTK pinctrl stuff upstream, and it seems there are a few
> > `mediatek,pull-*-adv` entries that have invalid values:
> >
> > arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi:
> > mediatek,pull-down-adv = <10>;
> > arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi:
> > mediatek,pull-down-adv = <10>;
> > arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi:
> > mediatek,pull-down-adv = <10>;
> > arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi:
> > mediatek,pull-up-adv = <10>;
> > arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi:
> > mediatek,pull-down-adv = <10>;
> > arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi:
> > mediatek,pull-up-adv = <10>;
> > arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi:
> > mediatek,pull-down-adv = <10>;
> > arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dts:
> >  mediatek,pull-down-adv = <10>;
> > arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dts:
> >  mediatek,pull-down-adv = <10>;
> > arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dts:
> >  mediatek,pull-down-adv = <10>;
> > arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dts:
> >  mediatek,pull-up-adv = <10>;
> > arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dts:
> >  mediatek,pull-down-adv = <10>;
> > arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dts:
> >  mediatek,pull-up-adv = <10>;
> >
> > According to the bindings, the values should 0~3. <10> is probably a
> > incorrect attempt at using binary representation, which is wrong. This
> > probably leads to the pull-up/down getting disabled or ignored.
> >
> > Cound people still working on these two devices take a look?
> >
> Thanks for pointing this out. It's an incorrect value but 10=0b1010 so
> the result is same as 2, since the driver test the value by checking
> the last 2 bit. We should still fix this in dts.

That probably explains why no one noticed.