Re: [PATCH v2] pinctrl: armada-37xx: Correct PWM pins definitions

[Linus Walleij <linus.walleij@xxxxxxxxxx>]

On Mon, Jul 19, 2021 at 1:29 PM Marek Behún <kabel@xxxxxxxxxx> wrote:

> The PWM pins on North Bridge on Armada 37xx can be configured into PWM
> or GPIO functions. When in PWM function, each pin can also be configured
> to drive low on 0 and tri-state on 1 (LED mode).
>
> The current definitions handle this by declaring two pin groups for each
> pin:
> - group "pwmN" with functions "pwm" and "gpio"
> - group "ledN_od" ("od" for open drain) with functions "led" and "gpio"
>
> This is semantically incorrect. The correct definition for each pin
> should be one group with three functions: "pwm", "led" and "gpio".
>
> Change the "pwmN" groups to support "led" function.
>
> Remove "ledN_od" groups. This cannot break backwards compatibility with
> older device trees: no device tree uses it since there is no PWM driver
> for this SOC yet. Also "ledN_od" groups are not even documented.
>
> Fixes: b835d6953009 ("pinctrl: armada-37xx: swap polarity on LED group")
> Signed-off-by: Marek Behún <kabel@xxxxxxxxxx>
> Acked-by: Rob Herring <robh@xxxxxxxxxx>
> ---
> Since v1 I've added Fixes tag and Rob's Acked-by.

Patch applied, sorry for taking such time with this.

Yours,
Linus Walleij