> From: Fabio Estevam <festevam@xxxxxxxxx> > Sent: Tuesday, July 13, 2021 8:25 PM > > The imx_pinctrl_soc_info structure content is never changed, so it can be > declared as 'const', like it is done on all other i.MX pinctrl drivers. > > Make it 'const' in this driver too. > > Signed-off-by: Fabio Estevam <festevam@xxxxxxxxx> Reviewed-by: Dong Aisheng <aisheng.dong@xxxxxxx> BTW, you missed pinctrl-imx8dxl.c. Can you change that one too? Regards Aisheng > --- > drivers/pinctrl/freescale/pinctrl-imx8qxp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pinctrl/freescale/pinctrl-imx8qxp.c > b/drivers/pinctrl/freescale/pinctrl-imx8qxp.c > index 4f97813ba8b7..0a0acc0038d0 100644 > --- a/drivers/pinctrl/freescale/pinctrl-imx8qxp.c > +++ b/drivers/pinctrl/freescale/pinctrl-imx8qxp.c > @@ -194,7 +194,7 @@ static const struct pinctrl_pin_desc > imx8qxp_pinctrl_pads[] = { > IMX_PINCTRL_PIN(IMX8QXP_COMP_CTL_GPIO_1V8_3V3_QSPI0B), > }; > > -static struct imx_pinctrl_soc_info imx8qxp_pinctrl_info = { > +static const struct imx_pinctrl_soc_info imx8qxp_pinctrl_info = { > .pins = imx8qxp_pinctrl_pads, > .npins = ARRAY_SIZE(imx8qxp_pinctrl_pads), > .flags = IMX_USE_SCU, > -- > 2.25.1