> +
> +static const struct of_device_id sm6115_tlmm_of_match[] = {
> + { .compatible = "qcom,sm4250-tlmm", },
> + { .compatible = "qcom,sm6115-tlmm", },
> + { }
> +};
>
Please do not add separate compatibles for 2 speedbins of the otherwise same SoC.
Otherwise, the driver looks very good.
Konrad
Re: [PATCH v4 2/2] drivers: qcom: pinctrl: Add pinctrl driver for sm6115
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: [PATCH v4 2/2] drivers: qcom: pinctrl: Add pinctrl driver for sm6115
- From: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxx>
- Date: Sat, 26 Jun 2021 01:39:35 +0200
- In-reply-to: <20210625102147.51162-3-iskren.chernev@gmail.com>
- References: <20210625102147.51162-1-iskren.chernev@gmail.com> <20210625102147.51162-3-iskren.chernev@gmail.com>
- User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0
- References:
- [PATCH v4 0/2] Add Pinctrl for SM4250 and SM6115
- From: Iskren Chernev
- [PATCH v4 2/2] drivers: qcom: pinctrl: Add pinctrl driver for sm6115
- From: Iskren Chernev
- [PATCH v4 0/2] Add Pinctrl for SM4250 and SM6115
- Prev by Date: [GIT PULL] Last pin control fixes for v5.13
- Next by Date: Re: [PATCH v4 1/2] dt-bindings: pinctrl: qcom: Add SM6115 pinctrl bindings
- Previous by thread: [PATCH v4 2/2] drivers: qcom: pinctrl: Add pinctrl driver for sm6115
- Next by thread: Re: [PATCH v4 2/2] drivers: qcom: pinctrl: Add pinctrl driver for sm6115
- Index(es):
 |