On 6/23/21 11:49 PM, Jason Wang wrote: > The if condition followed by BUG can be replaced to BUG_ON which is > more compact and formal in linux source. > > Signed-off-by: Jason Wang <wangborong@xxxxxxxxxx> Acked-by: Florian Fainelli <f.fainelli@xxxxxxxxx> Although I would rather completely remove this BUG_ON() and replace it with a WARN_ON() instead, no need to kill the machine for such a problem, however unlikely it is to appear. -- Florian
Re: [PATCH] pinctrl: bcm2835: Replace BUG with BUG_ON
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: [PATCH] pinctrl: bcm2835: Replace BUG with BUG_ON
- From: Florian Fainelli <f.fainelli@xxxxxxxxx>
- Date: Thu, 24 Jun 2021 09:22:38 -0700
- In-reply-to: <20210624064913.41788-1-wangborong@cdjrlc.com>
- References: <20210624064913.41788-1-wangborong@cdjrlc.com>
- User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1
- Prev by Date: Re: [PATCH v3 1/2] dt-bindings: pinctrl: qcom: Add bindings for MDM9607
- Next by Date: Re: [PATCH v5 1/2] dt-bindings: gpio-cascade: add documentation
- Previous by thread: [PATCH v3 1/2] dt-bindings: pinctrl: qcom: Add bindings for MDM9607
- Next by thread: Re: [PATCH] pinctrl: bcm2835: Replace BUG with BUG_ON
- Index(es):
 |