Re: [PATCH 4/9] dt-bindings: gpio: change items restriction of clock for rockchip,gpio-bank

[Heiko Stübner <heiko@xxxxxxxxx>]

Hi Jay,

Am Freitag, 18. Juni 2021, 08:24:44 CEST schrieb Jianqun Xu:
> From: Liang Chen <cl@xxxxxxxxxxxxxx>
> 
> The clock property need 2 items on some rockchip chips.
> 
> Signed-off-by: Liang Chen <cl@xxxxxxxxxxxxxx>
> ---
>  .../devicetree/bindings/gpio/rockchip,gpio-bank.yaml         | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/gpio/rockchip,gpio-bank.yaml b/Documentation/devicetree/bindings/gpio/rockchip,gpio-bank.yaml
> index d993e002cebe..0d62c28fb58d 100644
> --- a/Documentation/devicetree/bindings/gpio/rockchip,gpio-bank.yaml
> +++ b/Documentation/devicetree/bindings/gpio/rockchip,gpio-bank.yaml
> @@ -22,7 +22,10 @@ properties:
>      maxItems: 1
>  
>    clocks:
> -    maxItems: 1
> +    minItems: 1
> +    items:
> +      - description: APB interface clock source
> +      - description: GPIO debounce reference clock source

as said in a previous mail, please adapt this to use clock-names for the
two clock variant. Maybe something like

clocks:
  minItems: 1
  maxItems: 2

clock-names:
  minItems: 1
  maxItems: 2
  items:
    - const: apb_pclk
    - const: debounce

if:
   properties:
     clocks:
       items:
         const: 2
then:
   required:
    - clock-names

[not yet sure if that works]



Heiko

>  
>    gpio-controller: true
>  
>