Re: [PATCH 0/6] pinctrl: ralink: move all pinmux arch stuff into driver code

[Sergio Paracuellos <sergio.paracuellos@xxxxxxxxx>]

Hi Linus,

On Mon, Jun 7, 2021 at 9:23 AM Linus Walleij <linus.walleij@xxxxxxxxxx> wrote:
>
> On Fri, Jun 4, 2021 at 1:52 PM Sergio Paracuellos
> <sergio.paracuellos@xxxxxxxxx> wrote:
>
> > We currently have 'drivers/pinctrl/ralink/' with common code to all of them
> > in 'pinctrl-rt2880.c' file. Pinctrl data was being passed in SoC initilization
> > to the driver. Instead of doing that just move all related code to the driver
> > itself. We maintain for all of them compatible string to avoid to make more
> > changes in dts's an so on. If a new compatible string is neccessary to be
> > defined for each different SoC, we can change them after this series are
> > applied.
> >
> > I have only tested MT7621 platform using GNUBee PC1 board. I don't have
> > other boards to test other SoC changes.
> >
> > This series are rebased on the master branch of linux-pinctrl git tree so
> > I expect this to be merged through pinctrl tree. Thomas, if 'linux-mips'
> > is preferred to merge this series just let me know and I can rebase them
> > to make you things easier.
> >
> > Thanks in advance for your time.
>
> I have simply applied all patches so we get some testing in linux-next
> (last time we found some snags through linux-next).

Good! Let's see what happen, then :)

>
> This is an important modernization of the ralink SoCs so I
> am pushing the fastforward button a bit.

I also do believe that having moved all of this stuff from the arch
headers to the driver itself is a very good step.

>
> If some ralink maintainer has opinions they can either patch it or
> complain loudly so I can take the patches out again.

Please, complain loudly if necessary :). As I said I only tested the
changes for mt7621 SoC, so it might be something wrong there.

>
> Yours,
> Linus Walleij

Thanks!
    Sergio Paracuellos