Re: [PATCH] gpio: regmap: move drvdata to config data

[Linus Walleij <linus.walleij@xxxxxxxxxx>]

On Fri, Jun 4, 2021 at 1:04 PM Michael Walle <michael@xxxxxxxx> wrote:

> Drop gpio_regmap_set_drvdata() and instead add it to the configuration
> data passed to gpio_regmap_register().
>
> gpio_regmap_set_drvdata() can't really be used in a race free way. This
> is because the gpio_regmap object which is needed by _set_drvdata() is
> returned by gpio_regmap_register(). On the other hand, the callbacks
> which use the drvdata might already be called right after the
> gpiochip_add() call in gpio_regmap_register(). Therefore, we have to
> provide the drvdata early before we call gpiochip_add().
>
> Reported-by: Matti Vaittinen <matti.vaittinen@xxxxxxxxxxxxxxxxx>
> Signed-off-by: Michael Walle <michael@xxxxxxxx>

Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

> Btw, I'm not sure how to handle this "was part of another patch by another
> author" thing. Should I leave the Sob and just add mine?

Ideally just stack Sign-offs it is called the "delivery path".

Yours,
Linus Walleij