Re: [PATCH v3 3/5] gpio: gpio-aspeed-sgpio: Add AST2600 sgpio support

[Andy Shevchenko <andy.shevchenko@xxxxxxxxx>]

On Fri, Jun 4, 2021 at 5:14 AM Steven Lee <steven_lee@xxxxxxxxxxxxxx> wrote:
> The 06/03/2021 19:05, Andy Shevchenko wrote:
> > On Thu, Jun 3, 2021 at 1:19 PM Steven Lee <steven_lee@xxxxxxxxxxxxxx> wrote:

> > > +#define GPIO_OFFSET(x)        ((x) & 0x1f)
> >
> > GENMASK()
> >
> > ...
> >
>
> Do you mean the macro should be modified as follows?
> #define GPIO_OFFSET(x)        ((x) & GENMASK(4, 0))

Yes.

-- 
With Best Regards,
Andy Shevchenko