Re: [PATCH 2/3] pinctrl: mediatek: don't hardcode mode encoding in common code

[Linus Walleij <linus.walleij@xxxxxxxxxx>]

On Fri, May 28, 2021 at 11:11 AM Fabien Parent <fparent@xxxxxxxxxxxx> wrote:

> -       bit = BIT(pin & 0xf);
> +       bit = BIT(offset & pctl->devdata->mode_mask);
>
> I should not have replaced 'pin' by 'offset' here. What do you
> recommend me to do here, shall I send a V2 of this series and you will
> drop my V1 from your tree, or do you want me to make a new patch that
> fixes the error created by this patch?

I just made the small patch myself, it's faster.
Sending it out as we speak.

Yours,
Linus Walleij