Re: [PATCH V3 3/3] dt-bindings: pinctrl: qcom-pmic-gpio: Convert qcom pmic gpio bindings to YAML

[skakit@xxxxxxxxxxxxxx]

On 2021-05-13 23:13, Guru Das Srinagesh wrote:
> On Wed, May 12, 2021 at 04:43:08PM +0530, satya priya wrote:
> > diff --git 
> > a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml 
> > b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml
> > new file mode 100644
> > index 0000000..85381a0
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml
> > @@ -0,0 +1,245 @@
> > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/pinctrl/qcom,pmic-gpio.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Qualcomm PMIC GPIO block
> > +
> > +maintainers:
> > +  - Bjorn Andersson <bjorn.andersson@xxxxxxxxxxxxxx>
> > +
> > +description: |
> > +  This binding describes the GPIO block(s) found in the 8xxx series 
> > of
> > +  PMIC's from Qualcomm.
> > +
> > +properties:
> > +  compatible:
> > +    items:
> > +      - enum:
> > +          - qcom,pm8005-gpio
>
> pm8008 has been missed out in the yaml file during the conversion. 
> could
> you please add this as well?

Will add it, thanks.

> > +          - qcom,pm8018-gpio
> > +          - qcom,pm8038-gpio
> > +          - qcom,pm8058-gpio
> > +          - qcom,pm8916-gpio
> > +          - qcom,pm8917-gpio
> > +          - qcom,pm8921-gpio
> > +          - qcom,pm8941-gpio
> > +          - qcom,pm8950-gpio
> > +          - qcom,pm8994-gpio
> > +          - qcom,pm8998-gpio
> > +          - qcom,pma8084-gpio
> > +          - qcom,pmi8950-gpio
> > +          - qcom,pmi8994-gpio
> > +          - qcom,pmi8998-gpio
> > +          - qcom,pms405-gpio
> > +          - qcom,pm660-gpio
> > +          - qcom,pm660l-gpio
> > +          - qcom,pm8150-gpio
> > +          - qcom,pm8150b-gpio
> > +          - qcom,pm6150-gpio
> > +          - qcom,pm6150l-gpio
> > +          - qcom,pmx55-gpio
> > +          - qcom,pm7325-gpio
> > +          - qcom,pm8350c-gpio
> > +          - qcom,pmk8350-gpio
> > +          - qcom,pmr735a-gpio
> > +
> > +      - enum:
> > +          - qcom,spmi-gpio
> > +          - qcom,ssbi-gpio
> > +
> > +  reg:
> > +    maxItems: 1
> > +
> > +  interrupts:
> > +    minItems: 1
> > +    maxItems: 44
> > +
> > +  '#interrupt-cells':
> > +    const: 2
> > +
> > +  interrupt-controller: true
> > +
> > +  gpio-controller: true
> > +
> > +  gpio-ranges:
> > +    maxItems: 1
> > +
> > +  '#gpio-cells':
> > +    const: 2
> > +    description: |
> > +        The first cell will be used to define gpio number and the
> > +        second denotes the flags for this gpio
> > +
> > +  gpio-keys:
> > +    type: object
> > +    properties:
> > +      volume-keys:
> > +        type: object
> > +        anyOf:
> > +          - $ref: "pinmux-node.yaml"
> > +          - $ref: "pincfg-node.yaml"
> > +        properties:
> > +          pins:
> > +            description: |
> > +                List of gpio pins affected by the properties 
> > specified in
> > +                this subnode.  Valid pins are
> > +                     - gpio1-gpio4 for pm8005
>
> pm8008 has been missed out in the yaml file during the conversion. 
> could
> you please add this as well?
>
> > +                     - gpio1-gpio6 for pm8018
> > +                     - gpio1-gpio12 for pm8038
> > +                     - gpio1-gpio40 for pm8058