On Wed, May 12, 2021 at 5:01 AM Zou Wei <zou_wei@xxxxxxxxxx> wrote: > > This patch adds missing MODULE_DEVICE_TABLE definition which generates > correct modalias for automatic loading of this driver when it is built > as an external module. > > Reported-by: Hulk Robot <hulkci@xxxxxxxxxx> > Signed-off-by: Zou Wei <zou_wei@xxxxxxxxxx> > --- > drivers/gpio/gpio-cadence.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpio/gpio-cadence.c b/drivers/gpio/gpio-cadence.c > index a4d3239..4ab3fcd 100644 > --- a/drivers/gpio/gpio-cadence.c > +++ b/drivers/gpio/gpio-cadence.c > @@ -278,6 +278,7 @@ static const struct of_device_id cdns_of_ids[] = { > { .compatible = "cdns,gpio-r1p02" }, > { /* sentinel */ }, > }; > +MODULE_DEVICE_TABLE(of, cdns_of_ids); > > static struct platform_driver cdns_gpio_driver = { > .driver = { > -- > 2.6.2 > The tag should be just regular [PATCH] as this driver has been upstream for a long time. Applied for fixes, thanks! Bartosz