Hi Andy, I love your patch! Perhaps something to improve: [auto build test WARNING on gpio/for-next] [also build test WARNING on v5.13-rc1 next-20210510] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Andy-Shevchenko/gpiolib-Introduce-for_each_gpio_desc-macro/20210511-035305 base: https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-gpio.git for-next config: riscv-randconfig-r011-20210510 (attached as .config) compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 492173d42b32cb91d5d0d72d5ed84fcab80d059a) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install riscv cross compiling tool for clang build # apt-get install binutils-riscv64-linux-gnu # https://github.com/0day-ci/linux/commit/ceaf41face19ca3a36b81b3b866c1708a90cb4e2 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Andy-Shevchenko/gpiolib-Introduce-for_each_gpio_desc-macro/20210511-035305 git checkout ceaf41face19ca3a36b81b3b866c1708a90cb4e2 # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 ARCH=riscv If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@xxxxxxxxx> All warnings (new ones prefixed by >>): >> drivers/gpio/gpiolib-of.c:718:32: warning: incompatible integer to pointer conversion passing 'unsigned long' to parameter of type 'const volatile unsigned long *'; take the address with & [-Wint-conversion] if (test_bit(FLAG_IS_HOGGED, desc->flags) && desc->hog == hog) ^~~~~~~~~~~ & include/linux/compiler.h:56:47: note: expanded from macro 'if' #define if(cond, ...) if ( __trace_if_var( !!(cond , ## __VA_ARGS__) ) ) ^~~~ include/linux/compiler.h:58:52: note: expanded from macro '__trace_if_var' #define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond)) ^~~~ include/asm-generic/bitops/non-atomic.h:104:66: note: passing argument to parameter 'addr' here static inline int test_bit(int nr, const volatile unsigned long *addr) ^ >> drivers/gpio/gpiolib-of.c:718:32: warning: incompatible integer to pointer conversion passing 'unsigned long' to parameter of type 'const volatile unsigned long *'; take the address with & [-Wint-conversion] if (test_bit(FLAG_IS_HOGGED, desc->flags) && desc->hog == hog) ^~~~~~~~~~~ & include/linux/compiler.h:56:47: note: expanded from macro 'if' #define if(cond, ...) if ( __trace_if_var( !!(cond , ## __VA_ARGS__) ) ) ^~~~ include/linux/compiler.h:58:61: note: expanded from macro '__trace_if_var' #define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond)) ^~~~ include/asm-generic/bitops/non-atomic.h:104:66: note: passing argument to parameter 'addr' here static inline int test_bit(int nr, const volatile unsigned long *addr) ^ >> drivers/gpio/gpiolib-of.c:718:32: warning: incompatible integer to pointer conversion passing 'unsigned long' to parameter of type 'const volatile unsigned long *'; take the address with & [-Wint-conversion] if (test_bit(FLAG_IS_HOGGED, desc->flags) && desc->hog == hog) ^~~~~~~~~~~ & include/linux/compiler.h:56:47: note: expanded from macro 'if' #define if(cond, ...) if ( __trace_if_var( !!(cond , ## __VA_ARGS__) ) ) ^~~~ include/linux/compiler.h:58:86: note: expanded from macro '__trace_if_var' #define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond)) ^~~~ include/linux/compiler.h:69:3: note: expanded from macro '__trace_if_value' (cond) ? \ ^~~~ include/asm-generic/bitops/non-atomic.h:104:66: note: passing argument to parameter 'addr' here static inline int test_bit(int nr, const volatile unsigned long *addr) ^ 3 warnings generated. vim +718 drivers/gpio/gpiolib-of.c 704 705 #ifdef CONFIG_OF_DYNAMIC 706 /** 707 * of_gpiochip_remove_hog - Remove all hogs in a hog device node 708 * @chip: gpio chip to act on 709 * @hog: device node describing the hogs 710 */ 711 static void of_gpiochip_remove_hog(struct gpio_chip *chip, 712 struct device_node *hog) 713 { 714 struct gpio_desc *desc; 715 unsigned int i; 716 717 for_each_gpio_desc(i, chip, desc) { > 718 if (test_bit(FLAG_IS_HOGGED, desc->flags) && desc->hog == hog) 719 gpiochip_free_own_desc(desc); 720 } 721 } 722 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx
Attachment:
.config.gz
Description: application/gzip
