Hi Rob,
On 2021-04-09 02:23, Rob Herring wrote:
On Thu, Apr 01, 2021 at 06:05:45PM +0530, satya priya wrote:
Convert Qualcomm PMIC GPIO bindings from .txt to .yaml format.
Signed-off-by: satya priya <skakit@xxxxxxxxxxxxxx>
---
Changes in V3:
- As per Rob's comments fixed bot erros.
- Moved this patch to end of the series so that other patches are not
blocked on this.
.../devicetree/bindings/pinctrl/qcom,pmic-gpio.txt | 280
--------------------
.../bindings/pinctrl/qcom,pmic-gpio.yaml | 281
+++++++++++++++++++++
2 files changed, 281 insertions(+), 280 deletions(-)
delete mode 100644
Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt
create mode 100644
Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml
diff --git
a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml
b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml
new file mode 100644
index 0000000..e7e7027
--- /dev/null
+++ b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml
@@ -0,0 +1,281 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/pinctrl/qcom,pmic-gpio.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Qualcomm PMIC GPIO block
+
+maintainers:
+ - Bjorn Andersson <bjorn.andersson@xxxxxxxxxxxxxx>
+
+description: |
+ This binding describes the GPIO block(s) found in the 8xxx series
of
+ PMIC's from Qualcomm.
+
+properties:
+ compatible:
+ items:
+ - enum:
+ - qcom,pm8005-gpio
+ - qcom,pm8018-gpio
+ - qcom,pm8038-gpio
+ - qcom,pm8058-gpio
+ - qcom,pm8916-gpio
+ - qcom,pm8917-gpio
+ - qcom,pm8921-gpio
+ - qcom,pm8941-gpio
+ - qcom,pm8950-gpio
+ - qcom,pm8994-gpio
+ - qcom,pm8998-gpio
+ - qcom,pma8084-gpio
+ - qcom,pmi8950-gpio
+ - qcom,pmi8994-gpio
+ - qcom,pmi8998-gpio
+ - qcom,pms405-gpio
+ - qcom,pm660-gpio
+ - qcom,pm660l-gpio
+ - qcom,pm8150-gpio
+ - qcom,pm8150b-gpio
+ - qcom,pm6150-gpio
+ - qcom,pm6150l-gpio
+ - qcom,pmx55-gpio
+ - qcom,pm7325-gpio
+ - qcom,pm8350c-gpio
+ - qcom,pmk8350-gpio
+ - qcom,pmr735a-gpio
+
+ - enum:
+ - qcom,spmi-gpio
+ - qcom,ssbi-gpio
Any combination of the 1st and 2nd entry is valid?
No, for pmics which use spmi and ssbi buses, "qcom,spmi-gpio" and
"qcom,ssbi-gpio" compatibles should be used respectively.
+
+ reg:
+ description: Register base of the GPIO block and length.
Just:
maxItems: 1
ok.
+
+ interrupts:
+ description: |
+ Must contain an array of encoded interrupt specifiers for
+ each available GPIO
Need to define how many interrupts. I assume there's some max.
ok will add maxItems.
+
+ '#interrupt-cells':
+ const: 2
+
+ interrupt-controller: true
+
+ gpio-controller: true
+
+ gpio-ranges:
+ maxItems: 1
+
+ '#gpio-cells':
+ const: 2
+ description: |
+ The first cell will be used to define gpio number and the
+ second denotes the flags for this gpio
+
+ gpio-keys:
+ type: object
+ properties:
+ volume-keys:
+ type: object
Needs a $ref to pinmux-node.yaml and pincfg-node.yaml.
can I add like below?
volume-keys:
type: object
+ anyOf:
+ - $ref: "pinmux-node.yaml"
+ - $ref: "pincfg-node.yaml"
+ properties:
+ pins:
+ description: |
+ List of gpio pins affected by the properties
specified in
+ this subnode. Valid pins are
+ - gpio1-gpio4 for pm8005
+ - gpio1-gpio6 for pm8018
+ - gpio1-gpio12 for pm8038
+ - gpio1-gpio40 for pm8058
+ - gpio1-gpio4 for pm8916
+ - gpio1-gpio38 for pm8917
+ - gpio1-gpio44 for pm8921
+ - gpio1-gpio36 for pm8941
+ - gpio1-gpio8 for pm8950 (hole on gpio3)
+ - gpio1-gpio22 for pm8994
+ - gpio1-gpio26 for pm8998
+ - gpio1-gpio22 for pma8084
+ - gpio1-gpio2 for pmi8950
+ - gpio1-gpio10 for pmi8994
+ - gpio1-gpio12 for pms405 (holes on gpio1, gpio9
+ and gpio10)
+ - gpio1-gpio10 for pm8150 (holes on gpio2,
gpio5,
+ gpio7 and gpio8)
+ - gpio1-gpio12 for pm8150b (holes on gpio3,
gpio4
+ and gpio7)
+ - gpio1-gpio12 for pm8150l (hole on gpio7)
+ - gpio1-gpio10 for pm6150
+ - gpio1-gpio12 for pm6150l
+ - gpio1-gpio10 for pm7325
+ - gpio1-gpio9 for pm8350c
+ - gpio1-gpio4 for pmk8350
+ - gpio1-gpio4 for pmr735a
+
+ $ref: /schemas/types.yaml#/definitions/string-array
Already has a type in pinmux-node.yaml.
Okay, will add above and remove here.
+ items:
+ pattern: "^gpio([0-9]+)$"
+
+ function:
+ $ref: /schemas/types.yaml#/definitions/string
ditto
Okay, will add above and remove here.
+ description: |
+ Specify the alternative function to be configured for
the
+ specified pins.
+ items:
+ - enum:
+ - normal
+ - paired
+ - func1
+ - func2
+ - dtest1
+ - dtest2
+ - dtest3
+ - dtest4
+ - func3 # supported by LV/MV GPIO subtypes
+ - func4 # supported by LV/MV GPIO subtypes
+
+ bias-disable:
+ $ref: /schemas/types.yaml#/definitions/flag
And all these have a type and description. Just:
bias-disable: true
If no further constraints.
Okay.
+ description:
+ The specified pins should be configured as no pull.
+
+ bias-pull-down:
+ $ref: /schemas/types.yaml#/definitions/flag
[...]
+ additionalProperties: true
+
+additionalProperties: true
Should be 'false'.
Okay.
Thanks,
Satya Priya
