Re: [PATCH 01/12] pinctrl: renesas: r8a7796: Add missing bias for PRESET# pin

[Niklas Söderlund <niklas.soderlund@xxxxxxxxxxxx>]

Hi Geert,

Thanks for your work.

On 2021-04-30 14:31:00 +0200, Geert Uytterhoeven wrote:
> R-Car Gen3 Hardware Manual Errata for Rev. 0.52 of Nov 30, 2016, added
> the configuration bit for bias pull-down control for the PRESET# pin on
> R-Car M3-W.  Add driver support for controlling pull-down on this pin.
> 
> Fixes: 2d40bd24274d2577 ("pinctrl: sh-pfc: r8a7796: Add bias pinconf support")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>

Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@xxxxxxxxxxxx>

> ---
>  drivers/pinctrl/renesas/pfc-r8a7796.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/pinctrl/renesas/pfc-r8a7796.c b/drivers/pinctrl/renesas/pfc-r8a7796.c
> index 44e9d2eea484ad5d..bbb1b436ded3123f 100644
> --- a/drivers/pinctrl/renesas/pfc-r8a7796.c
> +++ b/drivers/pinctrl/renesas/pfc-r8a7796.c
> @@ -67,6 +67,7 @@
>  	PIN_NOGP_CFG(QSPI1_MOSI_IO0, "QSPI1_MOSI_IO0", fn, CFG_FLAGS),	\
>  	PIN_NOGP_CFG(QSPI1_SPCLK, "QSPI1_SPCLK", fn, CFG_FLAGS),	\
>  	PIN_NOGP_CFG(QSPI1_SSL, "QSPI1_SSL", fn, CFG_FLAGS),		\
> +	PIN_NOGP_CFG(PRESET_N, "PRESET#", fn, SH_PFC_PIN_CFG_PULL_DOWN),\
>  	PIN_NOGP_CFG(RPC_INT_N, "RPC_INT#", fn, CFG_FLAGS),		\
>  	PIN_NOGP_CFG(RPC_RESET_N, "RPC_RESET#", fn, CFG_FLAGS),		\
>  	PIN_NOGP_CFG(RPC_WP_N, "RPC_WP#", fn, CFG_FLAGS),		\
> @@ -6218,7 +6219,7 @@ static const struct pinmux_bias_reg pinmux_bias_regs[] = {
>  		[ 4] = RCAR_GP_PIN(6, 29),	/* USB30_OVC */
>  		[ 5] = RCAR_GP_PIN(6, 30),	/* GP6_30 */
>  		[ 6] = RCAR_GP_PIN(6, 31),	/* GP6_31 */
> -		[ 7] = SH_PFC_PIN_NONE,
> +		[ 7] = PIN_PRESET_N,		/* PRESET# */
>  		[ 8] = SH_PFC_PIN_NONE,
>  		[ 9] = SH_PFC_PIN_NONE,
>  		[10] = SH_PFC_PIN_NONE,
> -- 
> 2.25.1
> 

-- 
Regards,
Niklas Söderlund