Re: [PATCH 1/2] gpio: Add support for IDT 79RC3243x GPIO controller

[Thomas Bogendoerfer <tsbogend@xxxxxxxxxxxxxxxx>]

On Wed, Apr 21, 2021 at 12:54:53PM +0300, Andy Shevchenko wrote:
> As I promised you, I will do a deep review later on, I'm giving you
> time to find issues yourself. That's how you may actually learn the
> things. It's solely your choice to follow or not, my promise will be
> kept and you will get an answer anyway.

so let's make it a challenge ;-)

I see I could use gpiochip_get_data() in few place. 

Is there more you see ?

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]