Re: [PATCH v4] pinctrl: rockchip: add support for rk3568

[Heiko Stübner <heiko@xxxxxxxxx>]

Hi Peter,

Am Samstag, 10. April 2021, 20:30:52 CEST schrieb Peter Geis:
> Good Afternoon,
> 
> I'm currently working on the rk3566 early bringup support in mainline
> and encountered an issue with this patch set.
> Unfortunately in the rk3568/rk3566 the gpio registers switched to the
> (16 bits write enable / 16 bits config) register format that other
> rockchip registers use.
> This differs from previous chips where all 32 bits were used for gpio
> configuration.
> The patch fails to account for this, which causes all gpios to fail to function.
> 
> For clarity, this only affects GPIO_SWPORT_DR and GPIO_SWPORT_DDR.
> 
> I'm currently working on a patch to fix this issue, but I know that
> you are planning on breaking out the gpio functions into a separate
> driver and wanted to make you aware of this immediately.

just pointing to Jianqun's series providing the gpio controller support:

https://lore.kernel.org/r/20210324064704.950104-1-jay.xu@xxxxxxxxxxxxxx

which introduces the necessary writemask-handling but seems to need an
update, judging by Ezequiel's reply to it.


Heiko


> Very Respectfully,
> Peter Geis
> 
> On Fri, Apr 9, 2021 at 8:38 AM Linus Walleij <linus.walleij@xxxxxxxxxx> wrote:
> >
> > On Fri, Apr 9, 2021 at 6:17 AM Ezequiel Garcia
> > <ezequiel@xxxxxxxxxxxxxxxxxxxx> wrote:
> >
> > > Seems we are missing the dt-bindings for the new compatible string
> > > "rockchip,rk3568-pinctrl". Is there a patch for it somewhere?
> >
> > Nope please send one :)
> >
> > Yours,
> > Linus Walleij
> >
> > _______________________________________________
> > Linux-rockchip mailing list
> > Linux-rockchip@xxxxxxxxxxxxxxxxxxx
> > http://lists.infradead.org/mailman/listinfo/linux-rockchip
>