On Wed, Mar 24, 2021 at 04:43:12PM +0100, Roger Pau Monne wrote: > When parsing the capability list make sure the offset is between the > MMIO region mapped in 'regs', or else the kernel hits a page fault. > > Adding the check is harmless, and prevents buggy or broken systems > from crashing the kernel if the capability linked list is somehow > broken. I don't think we need a dead code in the kernel. If you have a hardware to show this issue, I eagerly want to know this! -- With Best Regards, Andy Shevchenko
Re: [PATCH v2 2/2] intel/pinctrl: check capability offset is between MMIO region
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: [PATCH v2 2/2] intel/pinctrl: check capability offset is between MMIO region
- From: Andy Shevchenko <andriy.shevchenko@xxxxxxxxx>
- Date: Wed, 24 Mar 2021 19:02:27 +0200
- In-reply-to: <20210324154312.61878-3-roger.pau@citrix.com>
- Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
- References: <20210324154312.61878-1-roger.pau@citrix.com> <20210324154312.61878-3-roger.pau@citrix.com>
- References:
- [PATCH v2 0/2] intel/pinctrl: check some registers reads
- From: Roger Pau Monne
- [PATCH v2 2/2] intel/pinctrl: check capability offset is between MMIO region
- From: Roger Pau Monne
- [PATCH v2 0/2] intel/pinctrl: check some registers reads
- Prev by Date: Re: [PATCH v2 1/2] intel/pinctrl: check REVID register value for device presence
- Next by Date: Re: [PATCH v2 1/2] dt-bindings: gpio: Binding for Realtek Otto GPIO
- Previous by thread: [PATCH v2 2/2] intel/pinctrl: check capability offset is between MMIO region
- Next by thread: [PATCH v2 1/2] intel/pinctrl: check REVID register value for device presence
- Index(es):
 |