Re: [PATCH 4/6] pinctrl: renesas: Add PORT_GP_CFG_7 macros

[Niklas Söderlund <niklas.soderlund@xxxxxxxxxxxx>]

Hi Geert,

Thanks for your patch.

On 2021-03-03 14:26:17 +0100, Geert Uytterhoeven wrote:
> Add PORT_GP_CFG_7() and PORT_GP_7() helper macros, to be used by the
> r8a7791 subdriver.
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>

Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@xxxxxxxxxxxx>

> ---
>  drivers/pinctrl/renesas/sh_pfc.h | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/pinctrl/renesas/sh_pfc.h b/drivers/pinctrl/renesas/sh_pfc.h
> index 8dc0fbb012b0c970..fc8391712af8cf4b 100644
> --- a/drivers/pinctrl/renesas/sh_pfc.h
> +++ b/drivers/pinctrl/renesas/sh_pfc.h
> @@ -479,9 +479,13 @@ extern const struct sh_pfc_soc_info shx3_pinmux_info;
>  	PORT_GP_CFG_1(bank, 5,  fn, sfx, cfg)
>  #define PORT_GP_6(bank, fn, sfx)	PORT_GP_CFG_6(bank, fn, sfx, 0)
>  
> -#define PORT_GP_CFG_8(bank, fn, sfx, cfg)				\
> +#define PORT_GP_CFG_7(bank, fn, sfx, cfg)				\
>  	PORT_GP_CFG_6(bank, fn, sfx, cfg),				\
> -	PORT_GP_CFG_1(bank, 6,  fn, sfx, cfg),				\
> +	PORT_GP_CFG_1(bank, 6,  fn, sfx, cfg)
> +#define PORT_GP_7(bank, fn, sfx)	PORT_GP_CFG_7(bank, fn, sfx, 0)
> +
> +#define PORT_GP_CFG_8(bank, fn, sfx, cfg)				\
> +	PORT_GP_CFG_7(bank, fn, sfx, cfg),				\
>  	PORT_GP_CFG_1(bank, 7,  fn, sfx, cfg)
>  #define PORT_GP_8(bank, fn, sfx)	PORT_GP_CFG_8(bank, fn, sfx, 0)
>  
> -- 
> 2.25.1
> 

-- 
Regards,
Niklas Söderlund