Re: [PATCH 1/2] arm64: remove select PINCTRL_ROCKCHIP from ARCH_ROCKCHIP

["jay.xu@xxxxxxxxxxxxxx" <jay.xu@xxxxxxxxxxxxxx>]

Hi Heiko

I have seen [0] patch similar to this patch, but is there need to remove select GPIOLIB and PINCTRL_ROCKCHIP from ARCH_ROCKCHIP ?

[0]:https://patchwork.kernel.org/project/linux-rockchip/patch/20210316134059.2377081-1-geert+renesas@xxxxxxxxx/

Best regards
--------------
jay.xu@xxxxxxxxxxxxxx
>Prepare to make pinctrl driver of rockchip to be module able, this patch
>remove the select of PINCTRL_ROCKCHIP from ARCH_ROCKCHIP.
>
>Signed-off-by: Jianqun Xu <jay.xu@xxxxxxxxxxxxxx>
>---
> arch/arm64/Kconfig.platforms | 2 --
> drivers/pinctrl/Kconfig      | 4 ++++
> 2 files changed, 4 insertions(+), 2 deletions(-)
>
>diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms
>index 6eecdef538bd..0371cc02b448 100644
>--- a/arch/arm64/Kconfig.platforms
>+++ b/arch/arm64/Kconfig.platforms
>@@ -227,9 +227,7 @@ config ARCH_RENESAS
> config ARCH_ROCKCHIP
> bool "Rockchip Platforms"
> select ARCH_HAS_RESET_CONTROLLER
>-	select GPIOLIB
> select PINCTRL
>-	select PINCTRL_ROCKCHIP
> select PM
> select ROCKCHIP_TIMER
> help
>diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig
>index 03c62e1cb395..bf88aac7bcc6 100644
>--- a/drivers/pinctrl/Kconfig
>+++ b/drivers/pinctrl/Kconfig
>@@ -210,11 +210,15 @@ config PINCTRL_OXNAS
> config PINCTRL_ROCKCHIP
> bool
> depends on OF
>+	select GPIOLIB
> select PINMUX
> select GENERIC_PINCONF
> select GENERIC_IRQ_CHIP
> select MFD_SYSCON
> select OF_GPIO
>+	default ARCH_ROCKCHIP
>+	help
>+          This support pinctrl and gpio driver for Rockchip SoCs.
>
> config PINCTRL_SINGLE
> tristate "One-register-per-pin type device tree based pinctrl driver"
>--
>2.25.1
>
>
>
>