On Fri, Mar 5, 2021 at 1:39 AM Jianqun Xu <jay.xu@xxxxxxxxxxxxxx> wrote: > Make the rockchip pinctrl driver able to be module by unselect > PINCTRL_ROCKCHIP from ARCH_ROCKCHIP, then modify driver module define. This patch set fails like this: ERROR: modpost: "irq_gc_set_wake" [drivers/pinctrl/pinctrl-rockchip.ko] undefined! make[3]: *** [../scripts/Makefile.modpost:132: Module.symvers] Error 1 make[3]: *** Deleting file 'Module.symvers' make[2]: *** [/home/linus/linux-pinctrl/Makefile:1440: modules] Error 2 Probably this function needs to get exported. (Send a separate patch for that.) Yours, Linus Walleij Yours, Linus Walleij