Re: [libgpiod][PATCH 6/6] core: hide the GPIOD_API symbol

[Andy Shevchenko <andy.shevchenko@xxxxxxxxx>]

On Tue, Mar 9, 2021 at 5:20 PM Bartosz Golaszewski <brgl@xxxxxxxx> wrote:
>
> On Tue, Mar 9, 2021 at 4:07 PM Andy Shevchenko
> <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
> >
> > On Tue, Mar 09, 2021 at 02:26:39PM +0100, Bartosz Golaszewski wrote:
> > > From: Bartosz Golaszewski <bgolaszewski@xxxxxxxxxxxx>
> > >
> > > GPIOD_API is unneccesarily polluting the user-facing headers. There's no
> > > advantage to having it in public files. Let's make them internal to the
> > > library. Upcoming modifications will also make GPIOD_BIT() redundant so
> > > we'll be able to remove all macros unrelated to the main functionality
> > > from gpiod.h.
> >
> > > -libgpiodcxx_la_SOURCES = chip.cpp iter.cpp line.cpp line_bulk.cpp
> > > +libgpiodcxx_la_SOURCES = chip.cpp internal.h iter.cpp line.cpp line_bulk.cpp
> >
> > Don't we have something like _HEADERS ?
> >
>
> _HEADERS is for headers that are installed. Headers for internal use
> should be defined as part of sources in autotools.

TIL :-)

"The noinst_HEADERS variable can be used for such headers. However
when the header actually belongs to a single convenience library or
program, we recommend listing it in the program’s or library’s
_SOURCES variable (see Program Sources) instead of in noinst_HEADERS.
This is clearer for the Makefile.am reader. noinst_HEADERS would be
the right variable to use in a directory containing only headers and
no associated library or program."


-- 
With Best Regards,
Andy Shevchenko