On Fri, Mar 5, 2021 at 2:50 PM Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote: > > On Fri, Mar 05, 2021 at 02:06:54PM +0100, Rafael J. Wysocki wrote: > > On Fri, Mar 5, 2021 at 1:31 PM Andy Shevchenko > > <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote: > > > On Fri, Mar 05, 2021 at 11:18:23AM +0800, kernel test robot wrote: > > > > url: https://github.com/0day-ci/linux/commits/Andy-Shevchenko/gpiolib-switch-to-fwnode-in-the-core/20210304-230747 > > > > base: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git e749df1bbd23f4472082210650514548d8a39e9b > > > > > > > > [If your patch is applied to the wrong git tree, kindly drop us a note. > > > > And when submitting patch, we suggest to use '--base' as documented in > > > > https://git-scm.com/docs/git-format-patch] > > > > > > > > > > > > Error/Warning in current branch: > > > > > > > > drivers/gpio/gpiolib.c:3672:24: warning: passing argument 1 of 'is_acpi_node' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers] > > > > drivers/gpio/gpiolib.c:3675:24: warning: passing argument 1 of 'is_acpi_node' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers] > > > > drivers/gpio/gpiolib.c:3686:24: error: passing 'const struct fwnode_handle *' to parameter of type 'struct fwnode_handle *' discards qualifiers [-Werror,-Wincompatible-pointer-types-discards-qualifiers] > > > > drivers/gpio/gpiolib.c:3686:24: warning: passing argument 1 of 'is_acpi_node' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers] > > > > > > Yeah, yeah. The fix should be in Rafael's tree. > > > > > > Rafael, can you submit it as material for v5.12-rcX, please? > > > > What exactly do you want me to submit for 5.12-rc and why is it urgent? > > I'm talking about > https://lore.kernel.org/linux-acpi/20210302133721.GG3@xxxxxxxxxxxxxxxxxxxxxx/T/#u > > It's not urgent per se, but it rather makes life easier in case that my > GPIO fwnode patch series will be routed thru the different tree (and > I believe GPIO would like to have pull it as an immutable branch / tag). OK, just sent a PR with that change, thanks!