On Thu, Mar 4, 2021 at 2:28 PM Álvaro Fernández Rojas <noltari@xxxxxxxxx> wrote: > > El 4 mar 2021, a las 13:09, Andy Shevchenko <andy.shevchenko@xxxxxxxxx> escribió: > > On Thu, Mar 4, 2021 at 1:17 PM Álvaro Fernández Rojas <noltari@xxxxxxxxx> wrote: > >>> El 4 mar 2021, a las 11:43, Andy Shevchenko <andy.shevchenko@xxxxxxxxx> escribió: > >>> On Thu, Mar 4, 2021 at 10:57 AM Álvaro Fernández Rojas > >>> <noltari@xxxxxxxxx> wrote: > >>>> > >>>> Add a helper for registering BCM63XX pin controllers. > >>>> > >>>> Signed-off-by: Álvaro Fernández Rojas <noltari@xxxxxxxxx> > >>>> Signed-off-by: Jonas Gorski <jonas.gorski@xxxxxxxxx> > >>> > >>> This SoB is in a strange place. > >> > >> Why? > >> Can’t we both sign the patches? > > > > You can, but you have to follow the rules (see chapters 11-13 in the [1]). > > > >>> The order is wrong taking into account the From header (committer). So, > >>> it's not clear who is the author, who is a co-developer, and who is > >>> the committer (one person may utilize few roles). > >>> Check for the rest of the series as well (basically this is the rule > >>> of thumb to recheck entire code for the comment you have got at any > >>> single place of it). > >> > >> Jonas was the original author of this patches (sent back in 2016) and I’m just continuing his work and trying to get those patches upstreamed. > >> I don’t know how to do it correctly, so a little hint would be appreciated. > > > > There are two ways (depends on the amount of work you have done): > > - leave him as an original author (so Author field will have his name, > > not yours) and apply yours with Co-developed-by tag and SoB since you > > are co-developed and committed > > - other way around > > So I will move his SoB to the top, add a Co-developed-by referencing him before that and then leave my SoB as the last one. Yes, if it is what you, guys, agreed on and want to have. Something like this. Co-developed-by: Jonas SoB: Jonas SoB: you (and From in the email should be yours as one who submitted the change) > @Jonas are you OK with that? > > [1]: https://www.kernel.org/doc/html/latest/process/submitting-patches.html#sign-your-work-the-developer-s-certificate-of-origin -- With Best Regards, Andy Shevchenko