On Tue, Mar 2, 2021 at 4:35 PM Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote: > The initial value of the OF node based on presence of parent, but > at the same time this operation somehow appeared separately from others > that handle the OF case. On the other hand there is no need to assign > dev->fwnode in the OF case if code properly retrieves fwnode, i.e. > via dev_fwnode() helper. > > Amend gpiolib.c and gpiolib-of.c code in order to group OF operations. > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> I parsed it in my head a few times and it looks like it will end up working the same, so: Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx> Yours, Linus Walleij