Re: [PATCH] pinctrl: rockchip: add support for rk3568

[Johan Jonker <jbx6244@xxxxxxxxx>]

Hi Jianqun,

Before a new compatible string is used in your code it must be added to
the documentation with a separate patch to rockchip,pinctrl.txt .

To get a ack-by you must include:

robh+dt@xxxxxxxxxx
devicetree@xxxxxxxxxxxxxxx

Your patch should show up here after filtering:
https://patchwork.ozlabs.org/project/devicetree-bindings/list/

./scripts/checkpatch.pl --strict
0001-pinctrl-rockchip-add-support-for-rk3568.patch

WARNING: DT compatible string "rockchip,rk3568-pinctrl" appears
un-documented -- check ./Documentation/devicetree/bindings/
#424: FILE: drivers/pinctrl/pinctrl-rockchip.c:4547:
+	{ .compatible = "rockchip,rk3568-pinctrl",

On 2/23/21 8:24 AM, Jianqun Xu wrote:
> RK3568 SoCs have 5 gpio controllers, each gpio has 32 pins. GPIO supports
> set iomux, pull, drive strength, schmitt and slew rate.
> 
> Signed-off-by: Jianqun Xu <jay.xu@xxxxxxxxxxxxxx>
> ---

[..]

>  static const struct of_device_id rockchip_pinctrl_dt_match[] = {
>  	{ .compatible = "rockchip,px30-pinctrl",
>  		.data = &px30_pin_ctrl },
> @@ -4239,6 +4544,8 @@ static const struct of_device_id rockchip_pinctrl_dt_match[] = {
>  		.data = &rk3368_pin_ctrl },
>  	{ .compatible = "rockchip,rk3399-pinctrl",
>  		.data = &rk3399_pin_ctrl },
> +	{ .compatible = "rockchip,rk3568-pinctrl",
> +		.data = &rk3568_pin_ctrl },
>  	{},
>  };
>  
>