Re: [PATCH v2] pinctrl: single: set function name when adding function

[Linus Walleij <linus.walleij@xxxxxxxxxx>]

On Mon, Jan 25, 2021 at 9:36 PM Drew Fustini <drew@xxxxxxxxxxxxxxx> wrote:

> pcs_add_function() fails to set the function name in struct pcs_function
> when adding a new function.  As a result this line in pcs_set_mux():
>
>         dev_dbg(pcs->dev, "enabling %s function%i\n",
>                 func->name, fselector);
>
> prints "(null)" for the function:
>
> pinctrl-single 44e10800.pinmux: enabling (null) function0
> pinctrl-single 44e10800.pinmux: enabling (null) function1
> pinctrl-single 44e10800.pinmux: enabling (null) function2
> pinctrl-single 44e10800.pinmux: enabling (null) function3
>
> With this fix, the output is now:
>
> pinctrl-single 44e10800.pinmux: enabling pinmux-uart0-pins function0
> pinctrl-single 44e10800.pinmux: enabling pinmux-mmc0-pins function1
> pinctrl-single 44e10800.pinmux: enabling pinmux-i2c0-pins function2
> pinctrl-single 44e10800.pinmux: enabling pinmux-mmc0-pins function3
>
> Cc: Jason Kridner <jkridner@xxxxxxxxxxxxxxx>
> Cc: Robert Nelson <robertcnelson@xxxxxxxxxxxxxxx>
> Cc: Linus Walleij <linus.walleij@xxxxxxxxxx>
> Cc: Tony Lindgren <tony@xxxxxxxxxxx>
> Signed-off-by: Drew Fustini <drew@xxxxxxxxxxxxxxx>
> ---
> v2 change:
> - correctly base on mainline, sorry for the noise in v1

Patch applied!

Yours,
Linus Walleij