Re: [PATCH] pinctrl: samsung: use raw_spinlock for s3c64xx

[Krzysztof Kozlowski <krzk@xxxxxxxxxx>]

On Wed, Jan 27, 2021 at 09:16:31AM +0900, Chanho Park wrote:
> This patch converts spin_[lock|unlock] functions of pin bank to
> raw_spinlock to support preempt-rt for pinctrl-s3c64xx. Below patch
> converted spinlock_t to raw_spinlock_t but it didn't convert the
> s3c64xx's spinlock.

Please, don't use "This patch":
https://elixir.bootlin.com/linux/latest/source/Documentation/process/submitting-patches.rst#L89

The commit title should be changed - this is a fix now.

> 
> Fixes: 1f306ecbe0f6 ("pinctrl: samsung: use raw_spinlock for locking")
> 

No line break.

Best regards,
Krzysztof


> Cc: Tomasz Figa <tomasz.figa@xxxxxxxxx>
> Cc: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
> Cc: Sylwester Nawrocki <s.nawrocki@xxxxxxxxxxx>
> Cc: Linus Walleij <linus.walleij@xxxxxxxxxx>
> Signed-off-by: Chanho Park <chanho61.park@xxxxxxxxxxx>
> ---
>  drivers/pinctrl/samsung/pinctrl-s3c64xx.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/pinctrl/samsung/pinctrl-s3c64xx.c b/drivers/pinctrl/samsung/pinctrl-s3c64xx.c
> index b8166e3fe4ce..53e2a6412add 100644
> --- a/drivers/pinctrl/samsung/pinctrl-s3c64xx.c
> +++ b/drivers/pinctrl/samsung/pinctrl-s3c64xx.c
> @@ -286,14 +286,14 @@ static void s3c64xx_irq_set_function(struct samsung_pinctrl_drv_data *d,
>  	shift = shift * bank_type->fld_width[PINCFG_TYPE_FUNC];
>  	mask = (1 << bank_type->fld_width[PINCFG_TYPE_FUNC]) - 1;
>  
> -	spin_lock_irqsave(&bank->slock, flags);
> +	raw_spin_lock_irqsave(&bank->slock, flags);
>  
>  	val = readl(reg);
>  	val &= ~(mask << shift);
>  	val |= bank->eint_func << shift;
>  	writel(val, reg);
>  
> -	spin_unlock_irqrestore(&bank->slock, flags);
> +	raw_spin_unlock_irqrestore(&bank->slock, flags);
>  }
>  
>  /*
> -- 
> 2.30.0
>