Re: [pinctrl:devel 32/33] drivers/pinctrl/samsung/pinctrl-s3c64xx.c:296:25: error: passing argument 1 of 'spin_unlock_irqrestore' from incompatible pointer type

[Krzysztof Kozlowski <krzk@xxxxxxxxxx>]

On Tue, 26 Jan 2021 at 01:08, Chanho Park <chanho61.park@xxxxxxxxxxx> wrote:
>
> >         git fetch --no-tags pinctrl devel
> >         git checkout 1f306ecbe0f66681bd87a2bb9013630233a32f7f
> >         # save the attached .config to linux build tree
> >         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross
> > ARCH=c6x
> >
> > If you fix the issue, kindly add following tag as appropriate
> > Reported-by: kernel test robot <lkp@xxxxxxxxx>
> >
> > All errors (new ones prefixed by >>):
> >
> >    In file included from include/linux/wait.h:9,
> >                     from include/linux/pid.h:6,
> >                     from include/linux/sched.h:14,
> >                     from include/linux/ratelimit.h:6,
> >                     from include/linux/dev_printk.h:16,
> >                     from include/linux/device.h:15,
> >                     from drivers/pinctrl/samsung/pinctrl-s3c64xx.c:14:
> >    drivers/pinctrl/samsung/pinctrl-s3c64xx.c: In function
> > 's3c64xx_irq_set_function':
> > >> drivers/pinctrl/samsung/pinctrl-s3c64xx.c:289:20: error: passing
> > >> argument 1 of 'spinlock_check' from incompatible pointer type
> > >> [-Werror=incompatible-pointer-types]
> >      289 |  spin_lock_irqsave(&bank->slock, flags);
> >          |                    ^~~~~~~~~~~~
> >          |                    |
> >          |                    raw_spinlock_t * {aka struct raw_spinlock *}
> >    include/linux/spinlock.h:252:34: note: in definition of macro
> > 'raw_spin_lock_irqsave'
> >      252 |   flags = _raw_spin_lock_irqsave(lock); \
> >          |                                  ^~~~
> >    drivers/pinctrl/samsung/pinctrl-s3c64xx.c:289:2: note: in expansion of
> > macro 'spin_lock_irqsave'
> >      289 |  spin_lock_irqsave(&bank->slock, flags);
> >          |  ^~~~~~~~~~~~~~~~~
> >    In file included from include/linux/wait.h:9,
> >                     from include/linux/pid.h:6,
> >                     from include/linux/sched.h:14,
> >                     from include/linux/ratelimit.h:6,
> >                     from include/linux/dev_printk.h:16,
> >                     from include/linux/device.h:15,
> >                     from drivers/pinctrl/samsung/pinctrl-s3c64xx.c:14:
> >    include/linux/spinlock.h:327:67: note: expected 'spinlock_t *' {aka
> > 'struct spinlock *'} but argument is of type 'raw_spinlock_t *' {aka
> > 'struct raw_spinlock *'}
> >      327 | static __always_inline raw_spinlock_t
> *spinlock_check(spinlock_t
> > *lock)
> >          |
> ~~~~~~~~~~~~^~~~
> > >> drivers/pinctrl/samsung/pinctrl-s3c64xx.c:296:25: error: passing
> > >> argument 1 of 'spin_unlock_irqrestore' from incompatible pointer type
> > >> [-Werror=incompatible-pointer-types]
> >      296 |  spin_unlock_irqrestore(&bank->slock, flags);
> >          |                         ^~~~~~~~~~~~
> >          |                         |
> >          |                         raw_spinlock_t * {aka struct
> raw_spinlock *}
> >    In file included from include/linux/wait.h:9,
> >                     from include/linux/pid.h:6,
> >                     from include/linux/sched.h:14,
> >                     from include/linux/ratelimit.h:6,
> >                     from include/linux/dev_printk.h:16,
> >                     from include/linux/device.h:15,
> >                     from drivers/pinctrl/samsung/pinctrl-s3c64xx.c:14:
> >    include/linux/spinlock.h:407:64: note: expected 'spinlock_t *' {aka
> > 'struct spinlock *'} but argument is of type 'raw_spinlock_t *' {aka
> > 'struct raw_spinlock *'}
> >      407 | static __always_inline void spin_unlock_irqrestore(spinlock_t
> > *lock, unsigned long flags)
> >          |
> ~~~~~~~~~~~~^~~~
> >    cc1: some warnings being treated as errors
> >
> >
>
> Hi Linus,
>
> I was not aware PINCTRL_S3C64XX because it's not enabled in
> s3c6410_defconfig.
> Please pick the v2 patch. Sorry for the inconvenience.

For arm:
make allyesconfig
make -j4 drivers/pinctrl/samsung/

and indeed it does not compile...

Best regards,
Krzysztof